bu5hm4nn/vault-dash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(settings): fail closed on blank loan input

Browse Source
This commit is contained in:
Bu5hm4nn
2026-03-26 13:28:30 +01:00
parent 753e9d3146
commit ea3b384103
3 changed files with 65 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/roadmap/done/CORE-001D3A-alerts-settings-entrypoint-normalization.yaml
View File

@@ -17,4 +17,5 @@ completed_notes:
- Alert evaluation now compares thresholds through normalized Decimal-backed boundary values instead of ad-hoc `float(...)` extraction.
- Settings save-status formatting now snapshots numeric boundary values through a named adapter before rendering.
- Added focused regression tests for numeric-string coercion and bool fail-closed behavior in `tests/test_alerts.py` and `tests/test_settings.py`.
- Hardened `/{workspace_id}/settings` so blank loan input no longer silently saves as a zero-loan portfolio; the loan field now preserves blank state until validation and has a focused Playwright regression in `tests/test_settings_validation_playwright.py`.
- Validated with focused pytest coverage, browser-visible Playwright coverage, and `make build` on local Docker.